making L2 keyboard focusable #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Changeset has been found!This will create and publish a new version to NPM after a successful merge. |
emensch
reviewed
Feb 16, 2023
| @@ -356,7 +356,7 @@ export class Popover extends LitElement { | |||
| <slot name="content"></slot> | |||
| ${this.arrow ? html`<div id="arrow"></div>` : null} | |||
| </div> | |||
| <div id="trigger"> | |||
| <div id="trigger" tabindex="0"> | |||
There was a problem hiding this comment.
I think it might be better to let consumers decide how to implement a11y rather than forcing the decision on them here.
I suggest doing this on the verify side by passing focusin:focusout as a trigger type to cai-popover and adding tabindex="0" to <cai-indicator>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
making L2 open with keyboard
Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment