Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adding LibcontainerInstance for default implementation of Instance trait #226

Merged
merged 12 commits into from
Aug 14, 2023
+489 −287
Merged

refactor: adding LibcontainerInstance for default implementation of Instance trait #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
99f1015
refactor: add a new YoukiInstance for default implementation of Insta…
Mossaka Aug 3, 2023
355a267
docs: add some comments on the YoukiInstance trait
Mossaka Aug 3, 2023
f415b62
implement Instance for all instances of YoukiInstance
Mossaka Aug 3, 2023
bfb6819
docs: add more documentation to the youkiinstance
Mossaka Aug 3, 2023
157b888
feat: make libcontainer optional in containerd-shim-wasm
Mossaka Aug 4, 2023
21d8c67
group imports with conditional compilation
Mossaka Aug 4, 2023
2c310e0
refactor: apply Jorge's comments
Mossaka Aug 9, 2023
401d1fd
move youkiinstance to its own module
Mossaka Aug 10, 2023
0c944a4
make libcontainer an opt in feature
Mossaka Aug 10, 2023
644afd6
Merge remote-tracking branch 'upstream/main' into youki-containerd-sh…
Mossaka Aug 10, 2023
013247b
refactor: resolve more comments
Mossaka Aug 10, 2023
606f177
fixed a typo in the docs
Mossaka Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 209 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ thiserror = "1.0"
libc = "0.2.147"
oci-spec = { version = "0.6.1", features = ["runtime"] }
sha256 = "1.3.0"
libcontainer = "0.1"
libcontainer = { version = "0.1", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is default-features=false needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not, let me remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is needed because otherwise you will get this error

warning: /home/mossaka/developer/runwasi/crates/containerd-shim-wasm/Cargo.toml: `default-features` is ignored for libcontainer, since `default-features` was not specified for `workspace.dependencies.libcontainer`, this could become a hard error in the future


[profile.release]
panic = "abort"
Loading