Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOPNOTSUPP to err filter for PSI data #322

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mahendrapaipuri
Copy link
Contributor

When PSI is not enabled, the file reads will end up in Operation not supported error. Here is the relevant strace

mmap(NULL, 139264, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x154ea7496000
read(3, 0x154ea7497000, 131072)         = -1 EOPNOTSUPP (Operation not supported)

This PR adds EOPNOTSUPP to filter as well besides ENOTSUP.

@klihub
Copy link
Member

klihub commented Jan 17, 2024

@mahendrapaipuri nit: It would be preferable to squash those commits into a single one.

@mahendrapaipuri
Copy link
Contributor Author

mahendrapaipuri commented Jan 17, 2024

@klihub Makes sense! Will do it now!

edit:Squahsed commits and pushed. Let me know if it is good now.

* When PSI is not enabled attempting to read files end up in Operation Not Supported error which corresponds to EOPNOTSUPP error

* Add that error to filter to suppress inappropriate log message

Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
@dmcgowan dmcgowan merged commit c00d22e into containerd:main Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants