fix(schema): add "remove-unsafe-symlinks" #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What/why: implement detection/removal of unsafe symlinks in repos, specifically
covering cachi2 use case: Cachito already does this
How:
- copypasta `_enforce_sandbox()` and related unit tests from Cachito
("cachito/cachito/workers/tasks/general.py" and
"cachito/tests/test_workers/test_tasks/test_general.py", respectively)
- add call to `_enforce_sandbox()`
- add CLI boolean arg `remove-unsafe-symlinks`, which toggles removing all
symlinks which point to location(s) outside of any cloned repository
Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
Add "remove-unsafe-symlinks" to container.json schema Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
ben-alkov
force-pushed
the
fix-schema-add-remove-unsafe-symlinks
branch
from
34e9d99 to
3805623
Compare
|
Unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "remove-unsafe-symlinks" to container.json schem
Maintainers will complete the following section