Use Trustee-specific TCB Claims Extension #664
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the veraison annotated evidence extension to store the TCB Claims. This was a simplification, but it was not optimal. Thanks to some changes in the EAR crate, we can now easily store those claims in our own extension. Signed-off-by: Tobin Feldman-Fitzthum <tobin@ibm.com>
Now that we're using our own extension for TCB claims, the public key path is different. We could continue to support the old path as well, but I don't expect there to be any overlap. Signed-off-by: Tobin Feldman-Fitzthum <tobin@ibm.com>
We query the TCB claims to see which platform the evidence came from. Now that the TCB claims are in a new place, the policy will need to be adjusted slightly. This is a bit inconvenient but it shows why it's important to use the right extension in the first place. It's potentially very confusing to see veraison stuff in our policy. Signed-off-by: Tobin Feldman-Fitzthum <tobin@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a simplification, we are currently storing the tcb claims in the annotated evidence field of the EAR Appraisal. This field is actually an extension defined by veraison, so we end up with a token that had a veraison field in it even though we don't really follow the veraison protocol/spec.
Fortunately some recent changes to the EAR crate allow us to stick the tcb claims into our own extension. That's what this PR does. See commit messages for details.
This is going to be marked as a draft until the EAR crate has a release.