verifier: Rename user_data to report_data in SeAttestationClaims #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EAR token broker does not insert the `report_data` for SE attestation claim because there is no matching field in `SeAttestationClaims`. The absence leads to `TokenVerifierError(NoTeePubKeyClaimFound)` after successful attestation. As an interim solution, this commit renames the existing `user_data` to `report_data`, enabling the token broker to perform its task correctly. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
force-pushed
the
fix-report_data-for-se-verifier
branch
from
7f40050 to
4f0bfa4
Compare
mkulke
approved these changes
Jan 10, 2025
fitzthum
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
For some context, the EAR tokens will only expose the TEE public key if the verifier returns the report_data claim. This is by design. It means that for verifiers that don't check the binding of the report data, the token isn't very useful.
To work around this, we can add that claim to the output of the SE verifier. This is only a temporary workaround. The SE verifier will need to be improved to actually check the binding.
|
Also, btw I am preparing a PR to fix a similar issue for SNP, where we don't report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EAR token broker does not insert the
report_datafor SE attestation claim because there is no matching field inSeAttestationClaims. The absence leads toTokenVerifierError(NoTeePubKeyClaimFound)after successful attestation.As an interim solution, this PR renames the existing
user_datatoreport_data, enabling the token broker to perform its task correctly.Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com