Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Improve projects system #174

Closed
wants to merge 2 commits into from
Closed

Improve projects system #174

wants to merge 2 commits into from

Conversation

MattPlays
Copy link
Contributor

Automatically creates a Thread with a uuid when a message is sent in the special channel projects

closes #145

Copy link
Collaborator

@dylhack dylhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the same approach for the help channel. We should bring this to a generic method so that we do not need to repeat ourselves for each channel with threads.

@MattPlays
Copy link
Contributor Author

This looks like the same approach for the help channel. We should bring this to a generic method so that we do not need to repeat ourselves for each channel with threads.

I do believe a generic function would be much more helpful, However my only predicament probably because my brain is having a laugh is that How should special channels be flagged with they need a thread.

@dylhack
Copy link
Collaborator

dylhack commented Jul 24, 2022

Yeah, it looks like we need to allow multiple special channels with the same label. I will come around to this.

@MattPlays MattPlays requested a review from dylhack July 28, 2022 09:58
Comment on lines +50 to +53
(await getSpecialChannel(
message.guild?.id as string,
"projects"
)) as TextChannel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will crash

Comment on lines +43 to +46
(await getSpecialChannel(
message.guild?.id as string,
"help"
)) as TextChannel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will crash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylhack Ok but like, I have an issue. It doesnt crash.

const id = uuid().split("-");
const thId = id[id.length - 1];
const threadName = `Thread #${thId}`;
if (channel !== null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an impossible condition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it impossible? Say a server doesnt have the special channel set in the config.

(await getSpecialChannel(
    message.guild?.id as string,
    "projects"
)) as TextChannel

would be passed through as null no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylhack Actually, If you don't mind. Id like to postpone this until after the D.js v14 merge.
Ofc If that merge is actually happening.

@dylhack
Copy link
Collaborator

dylhack commented Aug 3, 2022

waiting for #176 to merge

@LeoCatsune
Copy link
Contributor

This has been untouched for a couple months but I think it can be closed seeing as we use a forums channel for this stuff now?

@MattPlays
Copy link
Contributor Author

This has been untouched for a couple months but I think it can be closed seeing as we use a forums channel for this stuff now?

Up to @dylhack

@MattPlays MattPlays closed this by deleting the head repository Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve projects system
3 participants