Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use civi jquery & update libs #23

Merged
merged 3 commits into from
Jul 17, 2017

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Jun 14, 2017

Updates to use Civi version of jQuery that is loaded by default
Allows use of civi_jquery and jquery_update modules - see #8
Restructure to recommended library locations
Script to pull latest libs
Update c3,d3,pivottable libraries

@aydun aydun mentioned this pull request Jun 14, 2017
@coldrunKacper
Copy link
Contributor

Hey Aydun, this PR looks nice and handy.
However recently we customized export_renderers.js to add CSV / TSV downloadable export + reformatted the code to make it more readable than original coffee script build result. It's because we assumed that maybe in the future we would want to add some other customization into it.
I think it would be good to exclude export_renderers.min.js for now and use our export_renderers.js from latest develop branch.
Could you recreate the PR to include this change and also use latest develop branch?

aydun added 3 commits July 14, 2017 12:10
Avoids conflicts with civi_jquery and jquery_update
Don't need additional jquery libs
Must set weights correctly to avoid $.pivotUtilities not defined error
@aydun aydun force-pushed the use-civi-jquery branch from 8be67a2 to da7770d Compare July 14, 2017 17:16
@aydun
Copy link
Contributor Author

aydun commented Jul 14, 2017

Rebased and modified to use Compucorp version of export_renderers.js

@coldrunKacper coldrunKacper merged commit 1b2c68c into compucorp:develop Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants