RSESPRT-57: Handle disabled review fields while Creating/Editing awards #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
changed the title
deb1990
force-pushed
the
RSESPRT-57-disabled-review-fields
branch
from
bba80ae to
4ac9e6e
Compare
deb1990
force-pushed
the
RSESPRT-57-disabled-review-fields
branch
from
4ac9e6e to
ca636e9
Compare
lisandro-compucorp
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR helps to handle Disabled Review Fields in a better way. While creating/editing an award, the disabled review fields will now be disabled in the Review Field Selection popup.
But if the disabled field is already part of an Award, it wont be shown anymore and will be removed when the award is saved again.
Before
Disabled review fields cannot be added/removed from the Review Field selection popup.
After
Disabled review fields can be added/removed from the Review Field selection popup.
