PCHR-4473: Run tests on CiviCRM 5.12.0

Jenkinsfile

@@ -49,7 +49,7 @@ pipeline {
       steps {
         script {
           // Build site with CV Buildkit
-          sh "civibuild create ${params.CIVIHR_BUILDNAME} --type drupal-clean --civi-ver 5.3.1 --url $WEBURL --admin-pass $ADMIN_PASS"
+          sh "civibuild create ${params.CIVIHR_BUILDNAME} --type drupal-clean --civi-ver 5.12.0 --url $WEBURL --admin-pass $ADMIN_PASS"
 
           // Get target and PR branches name
           def prBranch = env.CHANGE_BRANCH

com.civicrm.hrjobroles/hrjobroles.php

@@ -125,6 +125,7 @@ function hrjobroles_civicrm_tabset($tabsetName, &$tabs, $context) {
     $tabs[] = array( 'id' => 'hrjobroles',
       'url' => $url,
       'title' => 'Job Roles',
+      'icon' => 'crm-i fa-list-alt',
       'weight' => -180,
     );
   }

contactsummary/contactsummary.php

@@ -128,9 +128,9 @@ function contactsummary_civicrm_alterSettingsFolders(&$metaDataFolders = NULL) {
 function contactsummary_civicrm_pageRun($page) {
   if ($page instanceof CRM_Contact_Page_View_Summary) {
     CRM_Core_Resources::singleton()
-      ->addSetting(array(
-        'tabSettings' => array('active' => CRM_Utils_Request::retrieve('selectedChild', 'String', $this, FALSE, 'contactsummary')),
-      ))
+      ->addSetting([
+        'tabSettings' => ['active' => CRM_Utils_Request::retrieve('selectedChild', 'String') ?: 'contactsummary'],
+      ])
       ->addVars('leaveAndAbsences', [
         'baseURL' => CRM_Core_Resources::singleton()->getUrl('uk.co.compucorp.civicrm.hrleaveandabsences'),
         'attachmentToken' => CRM_Core_Page_AJAX_Attachment::createToken()
@@ -157,6 +157,7 @@ function contactsummary_civicrm_tabset($tabsetName, &$tabs, $context) {
       'id'     => 'contactsummary',
       'url'    => CRM_Utils_System::url('civicrm/contact-summary'),
       'title'  => ts('Contact Summary'),
+      'icon'   => 'crm-i fa-user',
       'weight' => -200,
     );
   }

hrbank/hrbank.php

@@ -104,3 +104,22 @@ function hrbank_civicrm_upgrade($op, CRM_Queue_Queue $queue = NULL) {
 function hrbank_civicrm_managed(&$entities) {
   return _hrbank_civix_civicrm_managed($entities);
 }
+
+/**
+ * Implementation of hook_civicrm_tabset
+ *
+ * @param string $tabsetName
+ * @param array $tabs
+ * @param mixed $context
+ */
+function hrbank_civicrm_tabset($tabsetName, &$tabs, $context) {
+  if ($tabsetName != 'civicrm/contact/view') {
+    return;
+  }
+
+  foreach ($tabs as $i => $tab) {
+    if ($tab['title'] == 'Bank Details') {
+        $tabs[$i]['icon'] = 'crm-i fa-bank';
+    }
+  }
+}

hrcareer/hrcareer.php

@@ -149,7 +149,7 @@ function hrcareer_getUFGroupID() {
  */
 function hrcareer_civicrm_buildProfile($name) {
   if ($name == 'hrcareer_tab') {
-    $isDialog = ('multiProfileDialog' == CRM_Utils_Request::retrieve('context', 'String', CRM_Core_DAO::$_nullObject));
+    $isDialog = ('multiProfileDialog' == CRM_Utils_Request::retrieve('context', 'String'));
 
     // To fix validation alert issue
     $smarty = CRM_Core_Smarty::singleton();
@@ -167,7 +167,7 @@ function hrcareer_civicrm_buildProfile($name) {
 
     $config = CRM_Core_Config::singleton();
     if ($config->logging && ! $isDialog) {
-      $contactID = CRM_Utils_Request::retrieve('id', 'Positive', $this);
+      $contactID = CRM_Utils_Request::retrieve('id', 'Positive');
       CRM_Core_Region::instance('profile-form-hrcareer_tab')->add(array(
         'template' => 'CRM/common/logButton.tpl',
         'instance_id' => CRM_Report_Utils_Report::getInstanceIDForValue('logging/contact/summary'),
@@ -192,3 +192,22 @@ function hrcareer_civicrm_pageRun($page) {
       ->addScriptFile('org.civicrm.hrcareer', 'js/dist/hrcareer.min.js', 1010);
   }
 }
+
+/**
+ * Implementation of hook_civicrm_tabset
+ *
+ * @param string $tabsetName
+ * @param array $tabs
+ * @param mixed $context
+ */
+function hrcareer_civicrm_tabset($tabsetName, &$tabs, $context) {
+  if ($tabsetName != 'civicrm/contact/view') {
+    return;
+  }
+
+  foreach ($tabs as $i => $tab) {
+    if ($tab['title'] == 'Career History') {
+        $tabs[$i]['icon'] = 'crm-i fa-history';
+    }
+  }
+}

hrident/hrident.php

@@ -140,8 +140,8 @@ function hrident_civicrm_buildProfile($name) {
     $smarty->assign('urlIsPublic', FALSE);
 
     $config = CRM_Core_Config::singleton();
-    if ($config->logging && 'multiProfileDialog' !== CRM_Utils_Request::retrieve('context', 'String', CRM_Core_DAO::$_nullObject)) {
-      $contactID = CRM_Utils_Request::retrieve('id', 'Positive', $this);
+    if ($config->logging && 'multiProfileDialog' !== CRM_Utils_Request::retrieve('context', 'String')) {
+      $contactID = CRM_Utils_Request::retrieve('id', 'Positive');
       CRM_Core_Region::instance('profile-form-hrident_tab')->add(array(
         'template' => 'CRM/common/logButton.tpl',
         'instance_id' => CRM_Report_Utils_Report::getInstanceIDForValue('logging/contact/summary'),