Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Fs 4096 - Adding current welsh translations #488

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Fs 4096 - Adding current welsh translations #488

merged 6 commits into from
Feb 27, 2024

Conversation

adamdavies1
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

  • Adding the current welsh translations to new welsh forms

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

  • Test A
  • Test B

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts
  • I have checked deployments are working in all environments
  • I have updated the architecture diagrams as per Contribute.md

Copy link

@RamuniN RamuniN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you resolve the merge conflicts please

@adamdavies1 adamdavies1 merged commit 25d60e7 into main Feb 27, 2024
21 of 22 checks passed
@adamdavies1 adamdavies1 deleted the FS-4096 branch February 27, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants