Document tag_format and centrally set default value
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was very confused about these different usages. Documenting them might be a good basis for future simplification.
This should be non-breaking unless users rely on the looser version validation of TAG_FORMAT_REGEXS compared to their `version_scheme`.
We've been using this default already in `normalize_tag`, but setting this value in the settings dict is cleaner.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 97.31% 97.41% +0.10%
==========================================
Files 42 42
Lines 2045 2090 +45
==========================================
+ Hits 1990 2036 +46
+ Misses 55 54 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
4 tasks
Lee-W
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
Thank @robertschweizer for your contribution! I just read it through, and everything looks good to me!
@woile I'm planning to merge this these days. Let me know if you want to take a deeper look.
Lee-W
added
pr-status: ready-to-merge
woile
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split out from #692.
Please review the commits separately.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context