-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use debhelper tools for dependency compilation and packaging #408
base: master
Are you sure you want to change the base?
Conversation
What does this get us over checkinstall? Looks a bit messier if anything |
Hmm. The package build of qtwayland5 silently fails with the most recent docker versions (buildx > 0.15.1):
These errors don't lead to a failed docker build, but just result in a empty .deb file that's installed, ultimately causing a segfault on device and no working UI. Rather than debugging and fixing checkinstall, I would prefer to move to a more recent and tested way of building the deb files. (Checkinstall was last updated in 2017). I cleaned up the PR a bit. |
f380766
to
555b03d
Compare
userspace/compile-ffmpeg.sh
Outdated
# avoid makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24. | ||
# with --disable-htmlpages | ||
# --disable-doc works too, disables building documentation completely | ||
# https://gist.github.com/omegdadi/6904512c0a948225c81114b1c5acb875 | ||
# https://github.com/7Ji/archrepo/issues/10 | ||
./configure --enable-shared --disable-static --disable-htmlpages | ||
make -j$(nproc) | ||
echo -e "override_dh_auto_configure:\n\t./configure --enable-shared --disable-static --disable-htmlpages" >> debian/rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anything else we can do here? it's really not clear what's going on here scanning this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like I see it starts with echo
and skip it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next step dpkg-buildpackage reads from the debian/rules files and overrides the configure step. You could also commit the file directly to the repo, then we could skip this echo steps.
555b03d
to
213a43a
Compare
c1c0c0d
to
0746108
Compare
Use debhelper tools for creation of the .deb packages rather than old checkinstall.