-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAGPRA Inventory QA #232
Merged
ray-lee
merged 10 commits into
collectionspace:master
from
mikejritter:nagpra-inventory-qa
Aug 28, 2024
Merged
NAGPRA Inventory QA #232
ray-lee
merged 10 commits into
collectionspace:master
from
mikejritter:nagpra-inventory-qa
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 590 590
Lines 12682 12682
Branches 2593 2593
=======================================
Hits 12452 12452
Misses 227 227
Partials 3 3 ☔ View full report in Codecov by Sentry. |
ray-lee
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1331
How should this be tested? Do these changes have associated tests?
npm run lint
andnpm run test
as a sanity checknpm run devserver
Archaeological Culture
cultureGroup/culture
field can source from archcultureDependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested against a local instance