Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAGPRA Inventory QA #232

Merged
merged 10 commits into from
Aug 28, 2024
Merged

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Add archculture to concept authority
  • Remove ulan/tgn from sources
  • Update inventoryGroup source to deaccessionapprovalgroup
  • Update inventoryStatus source to nagpradocumentationstatus
  • Relabel fields

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1331

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test as a sanity check
  • Run the devserver npm run devserver
  • Check that Concept contains Archaeological Culture
  • Check that the fields in NAGPRA Inventory no longer source from ulan or tgn
  • Check that the cultureGroup/culture field can source from archculture

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

@mikejritter mikejritter requested a review from ray-lee August 23, 2024 21:19
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (ebac971) to head (a3742f4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12682    12682           
  Branches     2593     2593           
=======================================
  Hits        12452    12452           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit ec38428 into collectionspace:master Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants