Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Held-in-Trust QA Updates #231

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Removes ulan from sources
  • Update agreementGroup to use deaccessionapprovalgroup
  • Update agreementStatus to use deaccessionapprovalstatus
  • Update labels to use Held-in-Trust

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1358

This has the changes requested from initial testing that Jessi and Jadeen did on the new procedure. It's mostly minor changes involving relabeling fields and updating sources for terms and autocomplete fields.

How should this be tested? Do these changes have associated tests?

  • Ensure all tests continue to pass: npm run lint and npm run test
  • Run the devserver npm run devserver
  • See that the changes exist:
    • Agreement approval should become Held-in-Trust status
    • Held-in-Trust group should be a term picker input using deaccessionapprovalgroup
    • Held-in-Trust status should be a term picker input using deaccessionapprovalstatus
    • No autocomplete fields should pull from ulan sources

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local install

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (5aace31) to head (8502d1d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12679    12679           
  Branches     2593     2607   +14     
=======================================
  Hits        12449    12449           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter requested a review from ray-lee August 21, 2024 22:57
Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 164b633 into collectionspace:master Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants