Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duty of Care Updates #229

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Fix pluralization for duty of care
  • Remove ulan from various sources
  • Update involvedParty label
  • Rename title to dutyOfCareTitle

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1332

These changes come from the testing done against Duty of Care. It changes the pluralization used in the ui and the schema, and updates the involvedParty label. I also noticed that the title was not always being pulled correctly from the services layer so it has been renamed to dutyOfCareTitle.

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test
  • Rebuild the other PRs and start collectionspace
  • Start the devserver, npm run devserver
  • Check that the Duty of Care procedure still saves, loads, and can be searched
  • Check that the pluralization of correct for Duties of Care
  • Check that the label is correct for involvedParties
  • Check that the title is returned correctly in searches

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (75261c1) to head (a092f97).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12679    12679           
  Branches     2593     2607   +14     
=======================================
  Hits        12449    12449           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit a094f37 into collectionspace:master Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants