Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1316: Add object count group fields #196

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?
Adds fields and updates the default form for object count fields

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1316

This is intended to replace the numberOfObjects field with a more complete set of fields to support reporting needs for archaeology and NAGPRA profiles.

How should this be tested? Do these changes have associated tests?

  • Rebuild collectionspace
  • See that the new term list exists under objectcounttypes
  • Create a collectionobject using the new fields and term

Dependencies for merging? Releasing to production?
We'll need to double check that the layout is what was expected. I wasn't sure which one was being used for the wireframes, and wanted to get this up to make testing the application layer PR easier.

It's likely that other profiles will need to be updated as well but that will be noted in the ticket.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

@mikejritter
Copy link
Contributor Author

@ray-lee fyi I set this PR as a draft as I still need to update the other templates if they include numberOfObjects

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90c22fe) 95.47% compared to head (174d920) 95.47%.

❗ Current head 174d920 differs from pull request most recent head 07fe122. Consider uploading reports for the commit 07fe122 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         555      555           
  Lines       10899    10899           
  Branches     1196     1196           
=======================================
  Hits        10406    10406           
  Misses        147      147           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter marked this pull request as ready for review January 25, 2024 20:26
Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 45a056c into collectionspace:master Jan 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants