Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1285: Expand Note Field for various procedures #192

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Updates layout and config for the approval group to allow for multiline notes
  • Updates layout and config for the loan status group to allow for multiline notes
  • Updates layout and config for the deaccession approval group to allow for multiline notes

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1285

This allows the note fields for various approval/status groups to be more useful for users as it will let them add more complete notes to the fields.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • For each of: acquisition, intake, loanin, loanout, objectexit, useofcollection
    • Go to create a new record and look at the approval/status/deaccession group and see the new layout and multiline input for the note
    • Create the record with the group fields filled out and verify it saves/reloads

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (894f53f) 95.47% compared to head (4f840af) 95.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         555      555           
  Lines       10897    10897           
  Branches     1196     1196           
=======================================
  Hits        10404    10404           
  Misses        147      147           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ray-lee ray-lee merged commit ad1d115 into collectionspace:master Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants