This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
HipSYCL to AdaptiveCpp update & fixes #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
requested review from
s-Nick,
muhammad-tanvir-1211 and
aacostadiaz
s-Nick
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Thank for your patch @OuadiElfarouki
I point out other hipsycl reference that could be updated to adaptiveCpp everything else LGTM
pgorlani
reviewed
Jan 29, 2024
Co-authored-by: Nicolò Scipione <9421873+s-Nick@users.noreply.github.com>
s-Nick
reviewed
Feb 15, 2024
s-Nick
approved these changes
Feb 15, 2024
Co-authored-by: Nicolò Scipione <9421873+s-Nick@users.noreply.github.com>
muhammad-tanvir-1211
approved these changes
Feb 29, 2024
muhammad-tanvir-1211
merged commit fec888f
into
codeplaysoftware:master
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the hipSYCL compilation in portBLAS including :
Compilation flows / Device targets compiled successfully at this stage :
Tests and benchmarks are conditionally disabled for some operators depending on the target device and AdaptiveCpp flow. Remaining tests (in each case) are passing for all tested devices above.