This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Reuse temporary memory allocations #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgorlani
requested review from
mehdi-goli,
s-Nick,
muhammad-tanvir-1211 and
aacostadiaz
pgorlani
force-pushed
the
sb_handle-temp-mem-pr
branch
from
c891716 to
d76c669
Compare
muhammad-tanvir-1211
approved these changes
Jan 9, 2024
pgorlani
force-pushed
the
sb_handle-temp-mem-pr
branch
from
d76c669 to
2f5fe4d
Compare
s-Nick
approved these changes
Jan 25, 2024
pgorlani
force-pushed
the
sb_handle-temp-mem-pr
branch
from
2f5fe4d to
9b4ca54
Compare
muhammad-tanvir-1211
merged commit 9d515e3
into
codeplaysoftware:master
3 checks passed
| temp_usm_size_map_t temp_usm_size_map_; | ||
|
|
||
| template <typename container_t> | ||
| void release_buff_mem_(const container_t& mem); |
There was a problem hiding this comment.
Sorry for the late comment. I think this one should be swapped with the release_usm_mem_ above.
| Temp_Mem_Pool(queue_t q) | ||
| : q_(q), | ||
| temp_buffer_map_tot_byte_size_(0), | ||
| temp_usm_map_tot_byte_size_(0) {} |
There was a problem hiding this comment.
the temp_usm_map_tot_byte_size_ is undefined if SB_ENABLE_USM is not defined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a pool of temporary memory allocations within the
sb_handler, which allows reusing them in order to save re-allocation time.