Enabed Complex data type for Gemm #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
requested review from
s-Nick,
muhammad-tanvir-1211,
pgorlani and
aacostadiaz
OuadiElfarouki
force-pushed
the
complex_gemm_pr
branch
from
6943043 to
0c8ab21
Compare
s-Nick
reviewed
Sep 21, 2023
OuadiElfarouki
force-pushed
the
complex_gemm_pr
branch
from
369c21a to
626d110
Compare
OuadiElfarouki
force-pushed
the
complex_gemm_pr
branch
from
693e124 to
b53d0f6
Compare
| @@ -186,5 +186,149 @@ struct Packetize { | |||
| } | |||
| }; | |||
|
|
|||
| #ifdef BLAS_ENABLE_COMPLEX | |||
There was a problem hiding this comment.
I think it's best if we move this to a separate file to avoid confusion between the normal load/store.
There was a problem hiding this comment.
Moved the complex section to gemm_load_store_complex.hpp
| } | ||
|
|
||
| if (batch > 1 && batch_type == gemm_batch_type_t::interleaved) { |
There was a problem hiding this comment.
We could move this if condition to before the call to reference_blas to avoid running the cgemm unnecessarily.
OuadiElfarouki
force-pushed
the
complex_gemm_pr
branch
3 times, most recently
from
c8b7fbe to
622318e
Compare
OuadiElfarouki
force-pushed
the
complex_gemm_pr
branch
from
622318e to
6a0e010
Compare
muhammad-tanvir-1211
approved these changes
Oct 24, 2023
muhammad-tanvir-1211
merged commit 19b0fed
into
codeplaysoftware:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends support to sycl::complex<float/double> data types to GEMM operators (gemm & batched extensions).
Main changes :
ext/oneapi/experimental/sycl_complex.hpp