Default hide geolcation

[anselmbradford]

• Geolocation button was showing up when geolocation was not supported
  (IE8). This hides the button by default and displays it only when
  geolocation is supported.
• Removes unneeded ERB.
• Fixes Move Services Near Me on filter above input field #503 - Moves geolocation button on inside location filter input
  field above the input field. This makes it so when the geolocation button is hidden
  initially the layout doesn’t change when the geolocation button shows up.

@monfresh Ready for review and merge. Aligns code here with that in smcgov#49

[anselmbradford]

Looks like:

[coveralls]

Coverage remained the same when pulling 3190908 on default-hide-geolcation into f1262b2 on master.

[anselmbradford]

This also hides geolocation in IE9, which would make #405 moot.

[monfresh]

The button is always hidden for me, even in browsers that support geolocation. I reset Safari to clear all cookies and cache. I tried adding console.log('geolocation is supported'); under if(navigator.geolocation), but I never see anything in the log.

[anselmbradford]

Try adding console.log(navigator.geolocation) above if (navigator.geolocation) { (e771258#diff-2793a1cdbb8ee2f568e44a91bb9f10ddL23). Do you see anything logged?

[monfresh]

Don't see anything logged with that either. Is it working for you?

[monfresh]

If I remove the "hide" from the class, I can see the button, so it sounds like the conditional is not passing, and therefore the class removal never happens.

[anselmbradford]

Yes, I opened Safari and performed a reset of all settings and was not able to repeat. This code has also been checked on SauceLabs VMs and does not show the button on IE8/IE9 there, but does otherwise.

If you don't see the console log above the conditional it means that script isn't running at all. Check that you don't have precompiled assets in public/assets/ or tmp

[anselmbradford]

Just confirmed it's showing on SauceLabs VMs:

• Safari 7 on Mavericks
• Chrome35 on Mavericks
• FF30 on Mavericks
• FF32 on Win7

It's not showing on IE8 as expected, but it is showing on IE9, which is actually the expected behavior. I guess I didn't wait long enough last time (#405 is still relevant then).

[monfresh]

Ah! Good catch. I did have public/assets. I must have precompiled locally a while back and forgotten about it. Removing them fixed it. I bet you that's probably what's causing the google translate issue as well.

[monfresh]

Good to merge. Sorry for the confusion!

[anselmbradford]

Ah, cool, no worries. Yeah that may explain it because the script in a view wouldn't be considered an asset so if the script is removed in a view partial that would update, but if that code is moved to a JS asset (as is the case in the goog translate branch) that wouldn't update because the JS that got loaded in would be pulled off the precompiled assets.