Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error where applicant name was not correct in metatdata sent with SNAP app. #724

Merged
merged 1 commit into from
May 17, 2024

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented May 17, 2024

There is one more issue that needs to be address - the way the owners name is parsed is oversimplified.

It will work with this name: "Bethany Seeger", but not correctly with "Sally Ann Seeger" where "Sally Ann" is the full first name.

This is only an issue in the Metadata file:

"Bethany Seeger" -> firstName: Bethany, LastName: Seeger
"Sally Ann Seeger" -> firstName: Sally, LastName: Sally

This PR does not fix that issue.

@bseeger
Copy link
Contributor Author

bseeger commented May 17, 2024

Here's what the data looks like now (with fake names, of course).

Screenshot 2024-05-17 at 3 15 28 PM

@lkemperman-cfa lkemperman-cfa temporarily deployed to la-doc-uploa-fix-metada-tha59i May 17, 2024 19:22 Inactive
@bseeger bseeger merged commit d2339e7 into main May 17, 2024
5 checks passed
@bseeger bseeger deleted the fix_metadata_in_zip_file branch May 17, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants