Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement household sensitive questions flow #348

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Oct 11, 2023

To Test

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-348 October 11, 2023 00:40 Inactive
Copy link
Contributor

@lkemperman-cfa lkemperman-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will use a similar action for the income screens! LGTM

Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the the selections I made on householdWhichPersonalSituations are not getting displayed when I continue and then go back to this page

@analoo
Copy link
Contributor Author

analoo commented Oct 11, 2023

Seems like the the selections I made on householdWhichPersonalSituations are not getting displayed when I continue and then go back to this page

You are absolutely right. When I check it locally, I can see that the the selections do stay selected. I think the delta is due to this change that you and I made last week in the form flow builder: codeforamerica/form-flow#401 (it's in my local copy but not in the version of form flow that we are accessing on the test site)

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-348 October 11, 2023 20:23 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-348 October 12, 2023 23:51 Inactive
@analoo analoo merged commit 54d5cbd into main Oct 12, 2023
5 checks passed
@analoo analoo deleted the implement-household-sensitive-questions-flow branch October 12, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants