Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template resolver for a new location for uswds templates #400

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

cy-by
Copy link
Contributor

@cy-by cy-by commented Oct 4, 2023

Question for reviewer:
I had to create both ThymeleafConfigurationUnloadedTest and ThymeleafConfigurationLoadedTest in separate files so that I could load different application properties. Ideally I would like it to be in one file, maybe with nested classes, but I wasn't able to figure it out. If you have suggestions that would improve this, I'm very open to it.

@cy-by cy-by force-pushed the uswds-feature-flag-185770089 branch 2 times, most recently from 9b21881 to d1d4bdb Compare October 10, 2023 16:22
@cy-by cy-by changed the title Add template resolver for a new location for uswds templates WIP: Add template resolver for a new location for uswds templates Oct 10, 2023
@cy-by cy-by force-pushed the uswds-feature-flag-185770089 branch from d1d4bdb to 1e88f85 Compare October 11, 2023 16:08
@cy-by cy-by changed the title WIP: Add template resolver for a new location for uswds templates Add template resolver for a new location for uswds templates Oct 11, 2023
Cypress Borg and others added 4 commits October 11, 2023 17:30
Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
Co-authored-by: Devon Hirth <dhirth@codeforamerica.org>
@cy-by cy-by force-pushed the uswds-feature-flag-185770089 branch from ae7f990 to 79d75fd Compare October 11, 2023 22:30
@cy-by cy-by requested a review from spokenbird October 11, 2023 22:31
@@ -2347,6 +2350,17 @@ form-flow:
path: 'name-of-file.yaml'
```

#### Design System

We are moving towards using a [custom theme](https://codeforamerica.github.io/uswds/dist/) of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might reword this. If I'm correct, it's actually setting the UWDS resolver to be used over the default, meaning that enabling it would turn on the USWDS resolver, but those templates will now replace the same ones from the Honeycrisp resolver? Meaning that turning this on will switch your application to using USWDS styles and components instead of Honeycrisp styles and components.

Copy link
Contributor

@spokenbird spokenbird Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this same issue when setting application properties with regards to whether or not to scan file uploads with ClamAV. I could not figure out a way to have different application properties on a test by test basis, even with nested classes.

I hate that it has to be done this way as two seperate tests, and I hate even more that I have to ask:

Do we want a third test that tests it defaults to Honeycrisp when no application property is set?

@spokenbird spokenbird merged commit e73e77a into main Oct 12, 2023
3 checks passed
@spokenbird spokenbird deleted the uswds-feature-flag-185770089 branch October 12, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants