Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: White widget backgrounds in the journal filter toolbar #21389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions pkg/systemd/logs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,20 @@
.pf-v5-c-toolbar {
--pf-v5-c-toolbar--BackgroundColor: var(--pf-v5-c-page__main-section--BackgroundColor);

// We want menu toggles and secondary buttons in light mode to have
// a white background to increase their text-to-background contrast
// and to match the SearchInput component.

html:not(.pf-v5-theme-dark) & {
.pf-v5-c-menu-toggle {
--pf-v5-c-menu-toggle--BackgroundColor: var(--pf-v5-global--BackgroundColor--100);
}

.pf-v5-c-button {
--pf-v5-c-button--m-secondary--BackgroundColor: var(--pf-v5-global--BackgroundColor--100);
}
}

// Make toolbar stretch to all the available space and wrap up to two lines
.pf-v5-c-toolbar__group:nth-child(3) {
flex-grow: 1;
Expand All @@ -141,11 +155,6 @@
.pf-v5-c-toolbar__expandable-content.pf-m-expanded .pf-v5-c-divider {
display: none;
}

// FIXME: When porting the selects to the PF5 select implementation drop this
.pf-v5-c-toolbar__item {
align-self: center;
}
}

.log-text-filter-popover-button {
Expand All @@ -156,12 +165,3 @@
color: var(--pf-v5-global--Color--100);
}
}

/* Menu toggles are transparent in light mode (but not in dark
mode). This makes them white on a white page (fine), but grey in a
grey toolbar. The deprecated Select had a white background. Let's
make MenuToggles match.
*/
html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) {
background-color: var(--pf-v5-global--BackgroundColor--100);
}
Loading