-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consoles: Allow configuring VNC #1973
base: main
Are you sure you want to change the base?
Conversation
There is more work to be done here, of course:
|
Can you add a screenshot of the current status please? Thanks! |
Yes! Thanks for having a look @garrett! A runing virtual machine looks and behaves exactly like before. The console card of a not running machine has details about VNC. Machine without VNC: Machine with default VNC: Machine with custom VNC: Dialog for editing the VNC config: Dialog for adding VNC: (None of the above is meant to be final, of course.) |
2842ed0
to
cd06f95
Compare
Thanks for adding the screenshots! I like what I'm seeing so far.
It looks like a great start though, and I think it can be banged into resembling the mockups for this. Thanks again for picking up the work on Machines! |
cd06f95
to
28c5c41
Compare
28c5c41
to
f5583f6
Compare
So that people can edit them or add VNC if it is missing.
f5583f6
to
78c6280
Compare
Via the "Consoles" card, when the machine is off.
This is the minimum to get #1795 finished, IMO, and we should not try to do more. Anything on top happens in #1972 and elsewhere, at its own pace.