Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image refresh for debian-testing #6730

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented Aug 12, 2024

Image refresh for debian-testing

@github-actions github-actions bot added the bot label Aug 12, 2024
@cockpituous cockpituous changed the title Image refresh for debian-testing WIP: 06af55a1f6f6: [no-test] Image refresh for debian-testing Aug 12, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous force-pushed the image-refresh-debian-testing-20240812-225222 branch from 93ea4ce to 54fd8f0 Compare August 12, 2024 22:52
cockpituous pushed a commit that referenced this pull request Aug 12, 2024
@cockpituous cockpituous changed the title WIP: 06af55a1f6f6: [no-test] Image refresh for debian-testing Image refresh for debian-testing Aug 12, 2024
@cockpituous
Copy link
Contributor

@martinpitt
Copy link
Member

martinpitt commented Aug 13, 2024

New AppArmor denial

audit: type=1400 audit(1723503632.836:152): apparmor="DENIED" operation="open" class="file" profile="libvirt-aabe06c9-c0ff-4128-a956-6bc1fe37fabe" name="/proc/sys/vm/max_map_count" pid=6865 comm="qemu-system-x86" requested_mask="r" denied_mask="r" fsuid=64055 ouid=0

Probably from libvirt-daemon (10.5.0-1 -> 10.6.0-1) , needs confirmation. Already reported to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076946 . I sent some additional information there, reported upstream at https://gitlab.com/libvirt/libvirt/-/issues/660 and created #6733


And we have to do something about that bridge crash -- it's not a regression from the image refresh, it also affects c-files PRs and is at the top of the weather report. It also affects Arch BTW.

It reproduces locally:

for i in `seq 10`; do TEST_OS=debian-testing test/check-application TestFiles.testSorting $RUNC || break; done

But after fixing that, it crashes like this:

asyncio-ERROR: Exception in callback None()
handle: <Handle cancelled>
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/cockpit/_vendor/systemd_ctypes/pathwatch.py", line 205, in invalidate
fd = self.walk()
^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/_vendor/systemd_ctypes/pathwatch.py", line 257, in walk
with Handle.open(name, os.O_PATH | os.O_NOFOLLOW | os.O_CLOEXEC, dir_fd=dirfd) as fd:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/_vendor/systemd_ctypes/pathwatch.py", line 110, in open
return cls(os.open(*args, **kwargs))
^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'crypto-policies'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/cockpit/transports.py", line 243, in write
n_bytes = os.write(self._out_fd, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/lib/python3/dist-packages/cockpit/transports.py", line 110, in _read_ready
self._protocol.data_received(data)
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 193, in data_received
result = self.consume_one_frame(self.buffer)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 143, in consume_one_frame
self.frame_received(data[start:end])
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 97, in frame_received
self.control_received(data)
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 107, in control_received
self.channel_control_received(channel, command, message)
File "/usr/lib/python3/dist-packages/cockpit/router.py", line 219, in channel_control_received
endpoint.do_channel_control(channel, command, message)
File "/usr/lib/python3/dist-packages/cockpit/channel.py", line 155, in do_channel_control
self.do_control(command, message)
File "/usr/lib/python3/dist-packages/cockpit/channel.py", line 133, in do_control
self.do_open(message)
File "/usr/lib/python3/dist-packages/cockpit/channels/filesystem.py", line 572, in do_open
self.path_watch = PathWatch(self.path, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/_vendor/systemd_ctypes/pathwatch.py", line 193, in __init__
self.invalidate()
File "/usr/lib/python3/dist-packages/cockpit/_vendor/systemd_ctypes/pathwatch.py", line 217, in invalidate
self._listener.do_identity_changed(None, self._errno)
File "/usr/lib/python3/dist-packages/cockpit/channels/filesystem.py", line 529, in do_identity_changed
self.report_error(err)
File "/usr/lib/python3/dist-packages/cockpit/channels/filesystem.py", line 472, in report_error
self.send_update({'error': {
File "/usr/lib/python3/dist-packages/cockpit/channels/filesystem.py", line 410, in send_update
self.send_json(updates)
File "/usr/lib/python3/dist-packages/cockpit/channel.py", line 332, in send_json
return self.send_text(pretty)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/channel.py", line 328, in send_text
return self.send_bytes(data.encode())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/cockpit/channel.py", line 296, in send_bytes
self.send_channel_data(self.channel, data)
File "/usr/lib/python3/dist-packages/cockpit/router.py", line 94, in send_channel_data
self.router.write_channel_data(channel, data)
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 179, in write_channel_data
self.transport.write(header + payload)
File "/usr/lib/python3/dist-packages/cockpit/transports.py", line 247, in write
self.abort(exc)
File "/usr/lib/python3/dist-packages/cockpit/transports.py", line 145, in abort
self._protocol.connection_lost(exc)
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 160, in connection_lost
self.close(exc)
File "/usr/lib/python3/dist-packages/cockpit/protocol.py", line 170, in close
self.do_closed(exc)
File "/usr/lib/python3/dist-packages/cockpit/router.py", line 245, in do_closed
self.eof_received()
File "/usr/lib/python3/dist-packages/cockpit/router.py", line 234, in eof_received
endpoint.do_close()
File "/usr/lib/python3/dist-packages/cockpit/channels/filesystem.py", line 533, in do_close
assert self.path_watch is not None
^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Fixed both in cockpit-project/cockpit#20880

@martinpitt martinpitt self-assigned this Aug 13, 2024
@martinpitt martinpitt force-pushed the image-refresh-debian-testing-20240812-225222 branch from 54fd8f0 to dee48a5 Compare August 13, 2024 04:20
@martinpitt
Copy link
Member

martinpitt commented Aug 13, 2024

It cleared up, but this TestMultiMachineVNC failure is persistent.

This is fortunately known. See cockpit-project/cockpit-machines#1764

Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvollmer mvollmer merged commit 4b8818c into main Aug 14, 2024
12 checks passed
mvollmer pushed a commit that referenced this pull request Aug 14, 2024
@mvollmer mvollmer deleted the image-refresh-debian-testing-20240812-225222 branch August 14, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants