Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification types toggles #78

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alisalama
Copy link
Contributor

@alisalama alisalama commented Apr 22, 2022

Hi,

This follows on from PR.

I've personally have found the number of notifications to be somewhat irritating (and my gf finds it irritating at night!!), so I've split out some configuration for some separate notification toggles. The reinforcement ones particularly so, as you tend to get a few in a row all at the same time and I just close them.

Obviously this is subjective, but nice to have the option to toggle them on/off.

Summary of changes

  1. Additional config in .env file so each type of notification can be toggled on or off separately (NOTIFICATION_SEND, NOTIFICATION_REINFORCE, NOTIFICATION_CLOSE and NOTIFICATION_NOTIFY_IDLE)
  2. Added if statements to each of the /bot/mining and /bot/looting scripts for sendIM(x) to respect the config.
  3. I have left all the errors on by default as these are obviously more important and may require action, but consolidated the error notification on the notify scripts in to one line as previously was sending two messages.
  4. On reinforcement script, updated "Borrowing" to "Borrowed" after the fact.
  5. Updated Readme with instructions

Thanks,
Ali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant