Fix/fix rapid deamon #76
Conversation
WalkthroughThis update to version 0.4.1 of the project Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (22)
Files skipped from review as they are similar to previous changes (11)
Additional Context UsedLanguageTool (503)
Additional comments not posted (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@cnpmjs/binding@0.4.0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (16)
- CHANGELOG.md (1 hunks)
- bindings/binding-darwin-amd64/CHANGELOG.md (1 hunks)
- bindings/binding-darwin-amd64/package.json (2 hunks)
- bindings/binding-darwin-arm64/CHANGELOG.md (1 hunks)
- bindings/binding-darwin-arm64/package.json (2 hunks)
- bindings/binding-linux-amd64/CHANGELOG.md (1 hunks)
- bindings/binding-linux-amd64/package.json (2 hunks)
- bindings/binding-linux-arm64/CHANGELOG.md (1 hunks)
- bindings/binding-linux-arm64/package.json (2 hunks)
- lerna.json (1 hunks)
- package.json (1 hunks)
- packages/binding/CHANGELOG.md (1 hunks)
- packages/binding/package.json (2 hunks)
- packages/cli/CHANGELOG.md (1 hunks)
- packages/cli/lib/deamon.js (3 hunks)
- packages/cli/package.json (2 hunks)
Files not reviewed due to errors (1)
- (no review received)
Additional Context Used
Additional comments not posted (18)
lerna.json (1)
2-2: The version update from "0.4.0" to "0.4.1" inlerna.jsonis consistent with the PR objectives and ensures that the project's versioning remains synchronized across its components.bindings/binding-linux-amd64/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
16-16: Adding"rapid_deamon"to the"files"list is a necessary step for ensuring that the daemon is included in the package, which aligns with the PR's goal of enhancing the daemon's integration across different platforms.bindings/binding-linux-arm64/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
19-19: Adding"rapid_deamon"to the"files"list is a necessary step for ensuring that the daemon is included in the package, which aligns with the PR's goal of enhancing the daemon's integration across different platforms.bindings/binding-darwin-amd64/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
20-20: Adding"rapid_deamon"to the"files"list is a necessary step for ensuring that the daemon is included in the package, which aligns with the PR's goal of enhancing the daemon's integration across different platforms.bindings/binding-darwin-arm64/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
20-20: Adding"rapid_deamon"to the"files"list is a necessary step for ensuring that the daemon is included in the package, which aligns with the PR's goal of enhancing the daemon's integration across different platforms.packages/binding/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" for the@cnpmjs/bindingpackage is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
21-24: Updating the versions of the platform-specific dependencies to "^0.4.1" ensures that the binding package remains compatible with the updated versions of the platform-specific bindings, aligning with the PR's goal of enhancing compatibility and functionality across different platforms.packages/cli/package.json (2)
3-3: The version update from "0.4.0" to "0.4.1" for the@cnpmjs/rapidpackage is consistent with the PR objectives, ensuring that the project's versioning remains synchronized across its components.
14-14: Updating the version of the dependency@cnpmjs/bindingto "^0.4.1" ensures that the CLI package remains compatible with the updated version of the binding package, aligning with the PR's goal of enhancing compatibility and functionality across different platforms.package.json (1)
55-55: Adding therapidVersionfield with the value"0.0.1"introduces a new versioning system or dependency tracking mechanism for therapid_deamon, which aligns with the PR's goal of enhancing the management and tracking of the daemon's version within the project.packages/cli/lib/deamon.js (3)
106-126: ThecompareVersionsfunction returnsfalsewhen both versions are equal, which might be misleading. Consider renaming the function to reflect its specific purpose (e.g.,isVersion1LessThanVersion2) or adjusting the return value to distinguish between equal versions and versions whereversion1is less thanversion2.
165-170: Usingkillall -9to stop the daemon and related processes is aggressive and might not be safe in all environments. Consider checking if the daemon is running before attempting to kill it. Additionally, ensure that potential errors fromexeca.commandand file operations are handled gracefully to avoid leaving the system in an inconsistent state.
236-239: Consider extracting the error message for version mismatch into a constant for easier maintenance and potential localization in the future. Additionally, adding more detailed logging for each step of the daemon initialization could aid in debugging and operational monitoring.packages/binding/CHANGELOG.md (1)
6-9: The version bump to0.4.1for the@cnpmjs/bindingpackage is correctly documented, following the conventional commit guidelines and maintaining consistency with the structure of the CHANGELOG.md file. Good job on ensuring clarity and correctness in the documentation of changes.
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
There's a spelling mistake in "rapid_deamon". It should be "rapid_daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
There's a spelling mistake in "rapid_deamon". It should be "rapid_daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
There's a spelling mistake in "rapid_deamon". It should be "rapid_daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
There's a spelling mistake in "rapid_deamon". It should be "rapid_daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
d2e06ff to
2e29384
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (7)
- bindings/binding-darwin-amd64/package.json (1 hunks)
- bindings/binding-darwin-arm64/package.json (1 hunks)
- bindings/binding-linux-amd64/package.json (1 hunks)
- bindings/binding-linux-arm64/package.json (1 hunks)
- integration/index.2.test.js (1 hunks)
- package.json (1 hunks)
- packages/cli/lib/deamon.js (3 hunks)
Files skipped from review as they are similar to previous changes (6)
- bindings/binding-darwin-amd64/package.json
- bindings/binding-darwin-arm64/package.json
- bindings/binding-linux-amd64/package.json
- bindings/binding-linux-arm64/package.json
- package.json
- packages/cli/lib/deamon.js
Additional Context Used
GitHub Check Runs (3)
linux-test (20.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permittedlinux-test (18.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permittedlinux-test (16.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permitted
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
2e29384 to
9af1fea
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (7)
- bindings/binding-darwin-amd64/package.json (1 hunks)
- bindings/binding-darwin-arm64/package.json (1 hunks)
- bindings/binding-linux-amd64/package.json (1 hunks)
- bindings/binding-linux-arm64/package.json (1 hunks)
- integration/index.2.test.js (1 hunks)
- package.json (1 hunks)
- packages/cli/lib/deamon.js (5 hunks)
Files skipped from review as they are similar to previous changes (6)
- bindings/binding-darwin-amd64/package.json
- bindings/binding-darwin-arm64/package.json
- bindings/binding-linux-amd64/package.json
- bindings/binding-linux-arm64/package.json
- package.json
- packages/cli/lib/deamon.js
Additional Context Used
GitHub Check Runs (3)
linux-test (20.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permittedlinux-test (18.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permittedlinux-test (16.x, ubuntu-20.04, bash, 3.9) success (3)
integration/index.2.test.js: [warning] 172-172:
it.only not permitted
integration/index.2.test.js
Outdated
| @@ -169,7 +169,7 @@ | |||
| assert.strictEqual(require(path.join(cwd, 'node_modules', 'esbuild/package.json')).version, '0.15.14'); | |||
| }); | |||
|
|
|||
| it('should auto clean when reinstall', async () => { | |||
| it.only('should auto clean when reinstall', async () => { | |||
There was a problem hiding this comment.
The use of it.only restricts the test runner to executing only this specific test case, which is generally not suitable for commits to the main branch as it prevents other tests from running. Consider removing it.only to ensure all tests are executed.
- it.only('should auto clean when reinstall', async () => {
+ it('should auto clean when reinstall', async () => {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| it.only('should auto clean when reinstall', async () => { | |
| it('should auto clean when reinstall', async () => { |
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
9af1fea to
63dd5e9
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (7)
- bindings/binding-darwin-amd64/package.json (1 hunks)
- bindings/binding-darwin-arm64/package.json (1 hunks)
- bindings/binding-linux-amd64/package.json (1 hunks)
- bindings/binding-linux-arm64/package.json (1 hunks)
- integration/index.2.test.js (1 hunks)
- package.json (1 hunks)
- packages/cli/lib/deamon.js (5 hunks)
Files skipped from review as they are similar to previous changes (7)
- bindings/binding-darwin-amd64/package.json
- bindings/binding-darwin-arm64/package.json
- bindings/binding-linux-amd64/package.json
- bindings/binding-linux-arm64/package.json
- integration/index.2.test.js
- package.json
- packages/cli/lib/deamon.js
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
63dd5e9 to
2a4c63f
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (7)
- bindings/binding-darwin-amd64/package.json (1 hunks)
- bindings/binding-darwin-arm64/package.json (1 hunks)
- bindings/binding-linux-amd64/package.json (1 hunks)
- bindings/binding-linux-arm64/package.json (1 hunks)
- integration/index.2.test.js (1 hunks)
- packages/cli/lib/deamon.js (5 hunks)
- packages/cli/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- bindings/binding-darwin-amd64/package.json
- bindings/binding-darwin-arm64/package.json
- bindings/binding-linux-amd64/package.json
- bindings/binding-linux-arm64/package.json
- integration/index.2.test.js
- packages/cli/lib/deamon.js
- packages/cli/package.json
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
2a4c63f to
12495da
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (6)
- bindings/binding-darwin-amd64/package.json (1 hunks)
- bindings/binding-darwin-arm64/package.json (1 hunks)
- bindings/binding-linux-amd64/package.json (1 hunks)
- bindings/binding-linux-arm64/package.json (1 hunks)
- packages/cli/lib/deamon.js (5 hunks)
- packages/cli/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- bindings/binding-darwin-amd64/package.json
- bindings/binding-darwin-arm64/package.json
- bindings/binding-linux-amd64/package.json
- bindings/binding-linux-arm64/package.json
- packages/cli/lib/deamon.js
- packages/cli/package.json
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
4 times, most recently
from
38a429d to
b52c034
Compare
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) |
There was a problem hiding this comment.
Typographical errors in daemon and multi.
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
- * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * fix multi daemon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612))Correct the spelling of "daemon" and "multi" in the changelog entries.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix multi daemon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
The changelog correctly documents the addition of rapid_deamon under version 0.4.1. However, the spelling of "deamon" should be corrected to "daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
The changelog correctly documents the addition of rapid_deamon under version 0.4.1. However, the spelling of "deamon" should be corrected to "daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
The changelog correctly documents the addition of rapid_deamon under version 0.4.1. However, the spelling of "deamon" should be corrected to "daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ### Bug Fixes | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
akitaSummer
force-pushed
the
fix/fix_rapid_deamon
branch
from
b52c034 to
d5365eb
Compare
packages/cli/lib/deamon.js
Outdated
| return true; | ||
| } | ||
| const v1Parts = version1.split('.'); | ||
| const v2Parts = version2.split('.'); |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
There was a problem hiding this comment.
Fix the typo in "mutli" to "multi".
- * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))
+ * fix multi deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) | |
| * fix multi deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
| **Note:** Version bump only for package @cnpmjs/binding | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
| **Note:** Version bump only for package @cnpmjs/binding | ||
|
|
There was a problem hiding this comment.
Remove duplicate version bump entries to maintain a clean and accurate changelog.
- ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22)
- **Note:** Version bump only for package @cnpmjs/binding
-
- ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22)
- **Note:** Version bump only for package @cnpmjs/bindingCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| **Note:** Version bump only for package @cnpmjs/binding | |
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| **Note:** Version bump only for package @cnpmjs/binding |
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit -->
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) |
There was a problem hiding this comment.
Remove duplicate entries for version 0.4.1 to maintain the accuracy and cleanliness of the changelog.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
There was a problem hiding this comment.
Correct the spelling of "daemon" and "multi" in the changelog entries.
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
- * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * fix multi daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix multi daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
|
|
||
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
There was a problem hiding this comment.
Correct the spelling mistake in "rapid_deamon" to "rapid_daemon".
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) |
|
|
||
|
|
||
|
|
||
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) |
There was a problem hiding this comment.
Ensure consistent markdown link formatting.
- ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22)
+ ## \[0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ## [0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) | |
| ## \[0.4.1](https://github.com/cnpm/rapid/compare/v0.4.0...v0.4.1) (2024-04-22) |
| ### Bug Fixes | ||
|
|
||
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) |
There was a problem hiding this comment.
Correct the spelling of "multi" and "daemon".
- * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612))
+ * fix multi daemon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * fix mutli deamon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) | |
| * fix multi daemon run ([429b083](https://github.com/cnpm/rapid/commit/429b08393b4fba00f65d47a7e633102fb3751612)) |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
There was a problem hiding this comment.
Correct spelling mistakes in the changelog.
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
- * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * fix multi_daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix multi_daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
|
|
||
|
|
||
|
|
||
|
|
||
| # [0.4.0](https://github.com/cnpm/rapid/compare/v0.3.0...v0.4.0) (2024-02-01) |
There was a problem hiding this comment.
Ensure consistent markdown link formatting.
- # [0.4.0](https://github.com/cnpm/rapid/compare/v0.3.0...v0.4.0) (2024-02-01)
+ # \[0.4.0](https://github.com/cnpm/rapid/compare/v0.3.0...v0.4.0) (2024-02-01)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| # [0.4.0](https://github.com/cnpm/rapid/compare/v0.3.0...v0.4.0) (2024-02-01) | |
| # \[0.4.0](https://github.com/cnpm/rapid/compare/v0.3.0...v0.4.0) (2024-02-01) |
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | ||
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
There was a problem hiding this comment.
Correct spelling mistakes in the changelog.
- * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
- * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))
+ * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627))
+ * fix multi_daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * add rapid_deamon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix mutli deamon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) | |
| * add rapid_daemon to package ([aa05edb](https://github.com/cnpm/rapid/commit/aa05edbe4f9d532db42e1a3e802bba2468126627)) | |
| * fix multi_daemon run ([a1c1f84](https://github.com/cnpm/rapid/commit/a1c1f84d8fcdb485facbf4b89875690e49e8739b)) |
Summary by CodeRabbit
rapid_deamonacross various platform-specific packages.compareVersionsandclearMetadatafunctions to improve daemon version management and cleanup.rapidVersionfield in the main package configuration.CHANGELOG.mdfiles andlerna.json.