Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - add German loadout documentation #37

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

PervonHarke
Copy link
Collaborator

When merged this pull request will:

  • rename multiple loadouts to add missing version identifiers to file names
  • removed one unneeded/unfinished role from deu_ca2010_fallschirmjaeger_flecktarn.sqf
  • added documentation for all German loadouts

IMPORTANT

  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.
  • Loadouts use standard filename format.
  • Loadouts are listed and documented in the respective readme file.

@PervonHarke PervonHarke added status/pending Pending decision area/documentation Improves Documentation labels Feb 19, 2024
@PervonHarke PervonHarke linked an issue Feb 19, 2024 that may be closed by this pull request
10 tasks
@PervonHarke
Copy link
Collaborator Author

This might close the linked issue regarding documentation. Though this PR will not completely resolve that specific issue,
it may need reopening once this PR is merged.

Or it will be unlinked before merging to prevent that.

@PervonHarke
Copy link
Collaborator Author

Possible thing to do is to change all "unknown" entries for the loadout versions to 1.3 since that has been the latest version for a long time and basically for every loadout in this folder.

@Tapawingo Tapawingo removed a link to an issue Feb 19, 2024
10 tasks
@Tapawingo Tapawingo linked an issue Feb 19, 2024 that may be closed by this pull request
10 tasks
@@ -249,7 +249,7 @@ if (_condition && _role in ["FWP"]) then
};

// EOD , HAS TO BE SET AS EOD INSIDE 3DEN EDITOR THROUGH ACE.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally you can set _unit as EOD by setting the ACE_isEOD variable on the unit similarly to how it's done for medics:

_unit setVariable ["ACE_isEOD", true, true]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly you can do the same for engineers:

_unit setVariable ["ace_isEngineer", 1, true];

0: Untrained, only be able to replace wheels, based on settings.
1: Engineer.
2: Advanced Engineer, allowing a higher level of repairs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will keep this in mind for future loadouts. Thank you.

@PervonHarke PervonHarke merged commit 70dc72d into master Feb 19, 2024
2 checks passed
@PervonHarke PervonHarke deleted the addgermandocumentation branch February 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improves Documentation status/pending Pending decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO - Document all loadouts
2 participants