Split controllers and webhooks into separate packages #3310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3304
What is this change about?
Having controllers in separate packages allows having a suite per a
controller. This has several benefits:
all the controllers/webhooks. Instead, the setup wires only the
controller/webhook that is being tested
unrelated controllers/webhooks. This allows tests to not care about
creating "valid" dependent objects, they only create dependent
objects with properties that are just relevant to the
controller/webhook under test
controllers/webhooks into consideration
neightbour controller, the test could simply set the desired state of
the dependent object. This makes the test simpler and easy to reason
about
This change follows several patterns:
CFAppReconciler
is renamed to justReconciler
cfapp_controller.go
is renamed tocontroller.go
In the process of the refactoring above, tests are refactored:
Does this PR introduce a breaking change?
No
Acceptance Steps
tests passing
Tag your pair, your PM, and/or team
@cloudfoundry/wg-cf-on-k8s