Use the ready condition builder in relevant controllers #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, * take the opportunity to slightly improve their tests * use the `korifiv1alpha1.StatusConditionReady` constant wherever it makes sense fixes #3237
tcdowney
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3237
What is this change about?
Korifi custom resources that have their
Readycondition set bycontrollers now utilise the ready condition builder pattern we recently
came up with. The afffected resources are:
While being here,
korifiv1alpha1.StatusConditionReadyconstant wherever itmakes sense
Does this PR introduce a breaking change?
No
Acceptance Steps
No functional change
Tag your pair, your PM, and/or team
@cloudfoundry/wg-cf-on-k8s