Use the ReadyConditionBuilder for all custom resources that have ready state #3237
Assignees
Labels
Comments
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, take the opportunity to slightly improve their tests fixes #3237 wip * Address added TODOs wip
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, take the opportunity to slightly improve their tests fixes #3237 wip * Address added TODOs wip
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, * take the opportunity to slightly improve their tests * use the `korifiv1alpha1.StatusConditionReady` constant wherever it makes sense fixes #3237 wip * Address added TODOs wip
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, * take the opportunity to slightly improve their tests * use the `korifiv1alpha1.StatusConditionReady` constant wherever it makes sense fixes #3237
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, * take the opportunity to slightly improve their tests * use the `korifiv1alpha1.StatusConditionReady` constant wherever it makes sense fixes #3237
danail-branekov
added a commit
that referenced
this issue
May 27, 2024
Korifi custom resources that have their `Ready` condition set by controllers now utilise the ready condition builder pattern we recently came up with. The afffected resources are: * CFPackage * CFOrg * CFSpace * CFProcess * AppWorkload While being here, * take the opportunity to slightly improve their tests * use the `korifiv1alpha1.StatusConditionReady` constant wherever it makes sense fixes #3237
tcdowney
added a commit
that referenced
this issue
May 29, 2024
Use the ready condition builder in relevant controllers
github-project-automation
bot
moved this from 🔄 In progress
to ✅ Done
in Korifi - Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Those resources are:
Check whether there are more types that are just using strings instead of using the
korifiv1alpha1.StatusConditionReadyconstantThe text was updated successfully, but these errors were encountered: