Skip to content

Commit

Permalink
Increases timeout of flaky test
Browse files Browse the repository at this point in the history
This commit increases the timeout of a known-flaky test from its default
(one second) to five seconds. As written, there's no better way to
"resolve" this issue than to wait longer. Hopefully this is long enough.

Hopefully resolves the following in CI (which is the most-common recent
failure for the 'test-unit-windows' Job)

```
  [FAILED] in [It] - C:/var/vcap/data/worker/work/containers/00003g9ti7d/tmp/build/860c4145/bosh-dns-release/src/bosh-dns/dns/main_test.go:1124 @ 07/29/24 21:59:42.589
  << Timeline

  [FAILED] Timed out after 1.002s.
  Expected
      <string>: 127.0.0.1
  to equal
      <string>: 127.0.0.3
  In [It] at: C:/var/vcap/data/worker/work/containers/00003g9ti7d/tmp/build/860c4145/bosh-dns-release/src/bosh-dns/dns/main_test.go:1124 @ 07/29/24 21:59:42.589
------------------------------
```
  • Loading branch information
klakin-pivotal committed Jul 29, 2024
1 parent 55c0ecc commit 381d456
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bosh-dns/dns/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1121,7 +1121,7 @@ var _ = Describe("main", func() {
Expect(answer).To(BeAssignableToTypeOf(&dns.A{}))

return answer.(*dns.A).A.String()
}).Should(Equal("127.0.0.3"))
}, 5*time.Second).Should(Equal("127.0.0.3"))

Eventually(func() []dns.RR {
c := &dns.Client{}
Expand Down

0 comments on commit 381d456

Please sign in to comment.