Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add package name to the PR artifacts #7724

Merged
merged 1 commit into from
Jan 10, 2025
Merged

ci: add package name to the PR artifacts #7724

merged 1 commit into from
Jan 10, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 10, 2025

Make it easier to find the artifact.

It can be hard to figure out the command without the name:

image

Compare with the comment on this PR


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: ci
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: ci
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: ci

@vicb vicb requested a review from a team as a code owner January 10, 2025 11:44
Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 2cd36be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

  Your code here

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-wrangler-7724

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7724/npm-package-wrangler-7724

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-wrangler-7724 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-workers-bindings-extension-7724 -O ./cloudflare-workers-bindings-extension.0.0.0-v437e4892a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v437e4892a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-create-cloudflare-7724 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-kv-asset-handler-7724

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-miniflare-7724

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-pages-shared-7724

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-unenv-preset-7724

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-vitest-pool-workers-7724

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-workers-editor-shared-7724

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-workers-shared-7724

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12708879468/npm-package-cloudflare-workflows-shared-7724

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vicb
Copy link
Contributor Author

vicb commented Jan 10, 2025

Thanks for the review

@vicb vicb merged commit 998d230 into main Jan 10, 2025
34 of 37 checks passed
@vicb vicb deleted the artifacts branch January 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants