Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate to a single rimraf version #7719

Merged
merged 1 commit into from
Jan 10, 2025
Merged

chore: consolidate to a single rimraf version #7719

merged 1 commit into from
Jan 10, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 10, 2025

Move rimraf to the default catalog.

Notes:

  • Using v5 as v6 requires node 20 or >= 22
  • @types are not needed (only ever executred from package.json)
  • Ordered catalog alphabetically

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tested by build
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner January 10, 2025 07:47
Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 26362d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-wrangler-7719

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7719/npm-package-wrangler-7719

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-wrangler-7719 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-workers-bindings-extension-7719 -O ./cloudflare-workers-bindings-extension.0.0.0-vbe55d2ab4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vbe55d2ab4.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-create-cloudflare-7719 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-kv-asset-handler-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-miniflare-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-pages-shared-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-unenv-preset-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-vitest-pool-workers-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-workers-editor-shared-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-workers-shared-7719
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12705394708/npm-package-cloudflare-workflows-shared-7719

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 54a8475 into main Jan 10, 2025
35 of 36 checks passed
@petebacondarwin petebacondarwin deleted the rimraf branch January 10, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants