Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CF-Connecting-IP for requests to the edge preview #7712

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 9, 2025

Make sure we don't pass on the CF-Connecting-IP header to the remote edge preview instance. Without this line, remote previews will fail with DNS points to prohibited IP


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa requested a review from a team as a code owner January 9, 2025 20:07
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: e237ee0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the e2e Run e2e tests on a PR label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-wrangler-7712

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7712/npm-package-wrangler-7712

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-wrangler-7712 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-workers-bindings-extension-7712 -O ./cloudflare-workers-bindings-extension.0.0.0-v39e5aa2d0.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v39e5aa2d0.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-create-cloudflare-7712 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-kv-asset-handler-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-miniflare-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-pages-shared-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-unenv-preset-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-vitest-pool-workers-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-workers-editor-shared-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-workers-shared-7712
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12697668171/npm-package-cloudflare-workflows-shared-7712

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.100.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 6439347 into main Jan 9, 2025
36 of 37 checks passed
@penalosa penalosa deleted the penalosa/fix-cf-connecting-ip branch January 9, 2025 20:56
@workers-devprod workers-devprod mentioned this pull request Jan 9, 2025
penalosa added a commit that referenced this pull request Jan 10, 2025
* Remove CF-Connecting-IP for requests to the edge preview

* Create honest-pillows-tease.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants