-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove express-based dev registry #7706
Conversation
🦋 Changeset detectedLatest commit: b5afb44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7706/npm-package-wrangler-7706 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-bindings-extension-7706 -O ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-create-cloudflare-7706 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-kv-asset-handler-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-miniflare-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-pages-shared-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-unenv-preset-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-vitest-pool-workers-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-editor-shared-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-shared-7706 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workflows-shared-7706 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/wrangler/metafile.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only this was #4633 😅 for a second I thought that was finally implemented
c1fc48b
to
ac72510
Compare
ac72510
to
b5afb44
Compare
* Remove Server Registry * some more * Create ten-eyes-tease.md * fix * remove metafile * fix rebase * fix lockfile
After turning the file based registry on by default in #7081, usage of the legacy registry has been near 0 (internal metrics). We've also had no recent bug reports related to the file based registry. As such, this PR removes the server based registry implementation.
Additionally, I did some deduping of dependencies (we previously had undici 5.28.4 & 5.28.2 included in the Wrangler bundle).
The result of both of the above is that Wrangler's bundle size is now just 4.4MB, down from the current 7.07MB 🎉