Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove express-based dev registry #7706

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 8, 2025

After turning the file based registry on by default in #7081, usage of the legacy registry has been near 0 (internal metrics). We've also had no recent bug reports related to the file based registry. As such, this PR removes the server based registry implementation.

Additionally, I did some deduping of dependencies (we previously had undici 5.28.4 & 5.28.2 included in the Wrangler bundle).

The result of both of the above is that Wrangler's bundle size is now just 4.4MB, down from the current 7.07MB 🎉


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: functionality is the same

@penalosa penalosa requested review from a team as code owners January 8, 2025 20:44
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: b5afb44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the e2e Run e2e tests on a PR label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7706/npm-package-wrangler-7706

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-bindings-extension-7706 -O ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-create-cloudflare-7706 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-kv-asset-handler-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-miniflare-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-pages-shared-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-unenv-preset-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-vitest-pool-workers-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-editor-shared-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-shared-7706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workflows-shared-7706

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only this was #4633 😅 for a second I thought that was finally implemented

@penalosa penalosa force-pushed the penalosa/remove-legacy-registry branch 2 times, most recently from c1fc48b to ac72510 Compare January 9, 2025 19:10
@penalosa penalosa force-pushed the penalosa/remove-legacy-registry branch from ac72510 to b5afb44 Compare January 10, 2025 01:28
@penalosa penalosa merged commit c63f1b0 into main Jan 10, 2025
31 checks passed
@penalosa penalosa deleted the penalosa/remove-legacy-registry branch January 10, 2025 02:57
penalosa added a commit that referenced this pull request Jan 10, 2025
* Remove Server Registry

* some more

* Create ten-eyes-tease.md

* fix

* remove metafile

* fix rebase

* fix lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants