-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify tsconfig templates #6957
Conversation
🦋 Changeset detectedLatest commit: c8c24fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-wrangler-6957 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6957/npm-package-wrangler-6957 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-wrangler-6957 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-create-cloudflare-6957 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-cloudflare-kv-asset-handler-6957 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-miniflare-6957 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-cloudflare-pages-shared-6957 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-cloudflare-vitest-pool-workers-6957 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-cloudflare-workers-editor-shared-6957 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11331798113/npm-package-cloudflare-workers-shared-6957 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me
What this PR solves / how to test
create-cloudflare
generates unnecessary verbosetsconfig.json
.I think it would be better to generate simpler configs not to confuse out users - simpler is better!
The current
tsconfig.json
templates are probably derived fromtsc --init
which does not make a lot of sense because they would be different for different version of TypeScript.Fixes N/A.
Author has addressed the following