Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): remove triggered_by annotation from createDeployment #5306

Merged

Conversation

taylorlee
Copy link
Contributor

This got lost in translation:
#5224 (comment)

What this PR solves / how to test

Fixes npx wrangler versions deploy --experimental-gradual-rollouts being rejected by the API, as triggered_by can't be set by the client.

Author has addressed the following

  • Tests

    • Not necessary because: experimental feature
  • Changeset (Changeset guidelines)

    • Included
  • Public documentation

    • Not necessary because: experimental feature, docs are WIP

@taylorlee taylorlee requested a review from a team as a code owner March 20, 2024 00:06
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 65fbb2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-wrangler-5306

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5306/npm-package-wrangler-5306

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-wrangler-5306 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-create-cloudflare-5306 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-cloudflare-kv-asset-handler-5306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-miniflare-5306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-cloudflare-pages-shared-5306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8351776236/npm-package-cloudflare-vitest-pool-workers-5306

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.35.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240314.0
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.68%. Comparing base (93150aa) to head (65fbb2f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5306      +/-   ##
==========================================
+ Coverage   71.64%   71.68%   +0.03%     
==========================================
  Files         312      312              
  Lines       16217    16217              
  Branches     4149     4149              
==========================================
+ Hits        11619    11625       +6     
+ Misses       4598     4592       -6     
Files Coverage Δ
packages/wrangler/src/versions/api.ts 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@RamIdeas RamIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a e2e test to ensure this fix works and stays working. I might merge this to release it quickly as testing this fix manually is trivial, but the e2e test will follow soon after.

@RamIdeas RamIdeas merged commit c60fed0 into cloudflare:main Mar 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants