-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: Add env.d.ts
to Nuxt template
#5157
Conversation
🦋 Changeset detectedLatest commit: 9d36e1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-wrangler-5157 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5157/npm-package-wrangler-5157 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-wrangler-5157 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-create-cloudflare-5157 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-kv-asset-handler-5157 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-miniflare-5157 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-pages-shared-5157 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-vitest-pool-workers-5157 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂 , with just one small suggestion
8edc514
to
9d36e1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5157 +/- ##
==========================================
+ Coverage 70.32% 70.38% +0.05%
==========================================
Files 298 298
Lines 15551 15551
Branches 4001 4001
==========================================
+ Hits 10936 10945 +9
+ Misses 4615 4606 -9 |
What this PR solves / how to test
Updates the Nuxt template by adding a
env.d.ts
file which updates the type difinition forH3EventContext
to include thecf
property from the request and anenv
type generated from the recently addedbuild-cf-types
script.Author has addressed the following