Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Add env.d.ts to Nuxt template #5157

Merged
merged 3 commits into from
Mar 5, 2024
Merged

C3: Add env.d.ts to Nuxt template #5157

merged 3 commits into from
Mar 5, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Mar 5, 2024

What this PR solves / how to test

Updates the Nuxt template by adding a env.d.ts file which updates the type difinition for H3EventContext to include the cf property from the request and an env type generated from the recently added build-cf-types script.

Author has addressed the following

@jculvey jculvey requested a review from a team as a code owner March 5, 2024 05:19
Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 9d36e1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-wrangler-5157

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5157/npm-package-wrangler-5157

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-wrangler-5157 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-create-cloudflare-5157 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-kv-asset-handler-5157
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-miniflare-5157
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-pages-shared-5157
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8159663603/npm-package-cloudflare-vitest-pool-workers-5157

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂 , with just one small suggestion

@jculvey jculvey force-pushed the c3-nuxt-add-env-type branch from 8edc514 to 9d36e1f Compare March 5, 2024 16:28
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (594d688) to head (9d36e1f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5157      +/-   ##
==========================================
+ Coverage   70.32%   70.38%   +0.05%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10936    10945       +9     
+ Misses       4615     4606       -9     

see 7 files with indirect coverage changes

@jculvey jculvey merged commit 01a53b2 into main Mar 5, 2024
23 checks passed
@jculvey jculvey deleted the c3-nuxt-add-env-type branch March 5, 2024 22:28
@workers-devprod workers-devprod mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants