Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove checks from PR template TODOS #5154

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

petebacondarwin
Copy link
Contributor

To make it clear that the developer has opted for TODO we don't now autocheck these boxes.

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

To make it clear that the developer has opted for TODO we don't now autocheck these boxes.
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 4, 2024 21:55
Copy link

changeset-bot bot commented Mar 4, 2024

⚠️ No Changeset found

Latest commit: 366338b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-wrangler-5154

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5154/npm-package-wrangler-5154

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-wrangler-5154 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-create-cloudflare-5154 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-cloudflare-kv-asset-handler-5154
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-miniflare-5154
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-cloudflare-pages-shared-5154
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147530490/npm-package-cloudflare-vitest-pool-workers-5154

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (040be5d) to head (366338b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5154      +/-   ##
==========================================
+ Coverage   70.31%   70.36%   +0.04%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10935    10942       +7     
+ Misses       4616     4609       -7     

see 6 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit f8808b2 into main Mar 5, 2024
17 checks passed
@petebacondarwin petebacondarwin deleted the fix-pr-template-todos branch March 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants