Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] chore: fix dependabot so that it used the correct package version #5151

Merged
merged 5 commits into from
Mar 6, 2024
Merged

[C3] chore: fix dependabot so that it used the correct package version #5151

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9f874a
[C3] chore: fix dependabot so that it used the correct package version
dario-piotrowicz Mar 4, 2024
27236be
update c3-e2e as well
dario-piotrowicz Mar 4, 2024
9b55ed7
convert c3-e2e-dependabot.yml to pull_request instead of pull_request…
dario-piotrowicz Mar 5, 2024
a39294b
add env variable COMMITS_TO_FETCH to remove magic number 3
dario-piotrowicz Mar 5, 2024
030809f
remove COMMITS_TO_FETCH and use 0 instead
dario-piotrowicz Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/c3-e2e-dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0
Copy link
Member Author

@dario-piotrowicz dario-piotrowicz Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: 0 would also work but it seems quite unnecessary in my opinion since it fetches everything (https://github.com/actions/checkout)

Screenshot 2024-03-05 at 13 29 51

but I'm happy to use 0 if we find it more clear/robust and don't care about the extra fetching, please let me know what you think 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been going with 0 because it guarantees that all the tags are also there, and generally no one is complaining about performance. So I would err on that side. It is very confusing if something is missing from the cloned repo because the errors are a bit vague.

Copy link
Member Author

@dario-piotrowicz dario-piotrowicz Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, changed to 0 🙂👍

fetch-depth: 3
ref: ${{ github.head_ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct fix is to change the trigger to pull_request rather than pull_request_target, which according to the docs runs the job in the context of the base of the PR rather than the HEAD.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable to me, thanks 🙂

I've update the trigger, please have another look 🙏


- name: Install Dependencies
uses: ./.github/actions/install-dependencies
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/c3-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0
fetch-depth: 3
ref: ${{ github.head_ref }}

- name: Install Dependencies
uses: ./.github/actions/install-dependencies
Expand Down
Loading