-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: Try to URL decode hyperdrive password and database name before sending them to API #5143
wrangler: Try to URL decode hyperdrive password and database name before sending them to API #5143
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | PostgreSQL Credentials | 0e82e17 | packages/wrangler/src/tests/hyperdrive.test.ts | View secret | |
- | Generic Database Assignment | ad18a0d | packages/wrangler/src/tests/hyperdrive.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-wrangler-5143 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5143/npm-package-wrangler-5143 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-wrangler-5143 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-create-cloudflare-5143 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-cloudflare-kv-asset-handler-5143 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-miniflare-5143 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-cloudflare-pages-shared-5143 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8239575878/npm-package-cloudflare-vitest-pool-workers-5143 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
==========================================
+ Coverage 70.33% 70.66% +0.32%
==========================================
Files 298 298
Lines 15512 15574 +62
Branches 3983 4003 +20
==========================================
+ Hits 10910 11005 +95
+ Misses 4602 4569 -33
|
787e9a8
to
3d95fc2
Compare
3d95fc2
to
0c535e7
Compare
What this PR solves / how to test
Fixes #SQC-153
I'm building on top of the changes in #5064
Author has addressed the following