Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "before getting started" section to contributing guide #5142

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

lrapoport-cf
Copy link
Contributor

@lrapoport-cf lrapoport-cf commented Mar 1, 2024

What this PR solves / how to test

Fixes N/A.
This PR adds a section to the contributing guide on what you should do before getting started.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: only adding to contributing guide
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: only adding to contributing guide
  • Public documentation

@lrapoport-cf lrapoport-cf requested a review from a team as a code owner March 1, 2024 21:43
Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: 1b234b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-wrangler-5142

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5142/npm-package-wrangler-5142

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-wrangler-5142 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-create-cloudflare-5142 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-kv-asset-handler-5142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-miniflare-5142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-pages-shared-5142
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-vitest-pool-workers-5142

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf lrapoport-cf marked this pull request as draft March 1, 2024 21:52
@admah
Copy link
Contributor

admah commented Mar 4, 2024

@lrapoport-cf is this ready for review?

@lrapoport-cf lrapoport-cf force-pushed the lrapoport/process-updates branch from 4ac2652 to 99107b0 Compare March 4, 2024 21:15
@lrapoport-cf lrapoport-cf marked this pull request as ready for review March 4, 2024 21:16
@lrapoport-cf
Copy link
Contributor Author

@admah yep it is now :)

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (040be5d) to head (1b234b3).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5142      +/-   ##
==========================================
+ Coverage   70.31%   70.36%   +0.04%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10935    10942       +7     
+ Misses       4616     4609       -7     

see 6 files with indirect coverage changes

@lrapoport-cf lrapoport-cf merged commit 04b37fc into main Mar 5, 2024
17 checks passed
@lrapoport-cf lrapoport-cf deleted the lrapoport/process-updates branch March 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants