-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "before getting started" section to contributing guide #5142
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-wrangler-5142 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5142/npm-package-wrangler-5142 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-wrangler-5142 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-create-cloudflare-5142 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-kv-asset-handler-5142 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-miniflare-5142 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-pages-shared-5142 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8150348417/npm-package-cloudflare-vitest-pool-workers-5142 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@lrapoport-cf is this ready for review? |
4ac2652
to
99107b0
Compare
@admah yep it is now :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5142 +/- ##
==========================================
+ Coverage 70.31% 70.36% +0.04%
==========================================
Files 298 298
Lines 15551 15551
Branches 4001 4001
==========================================
+ Hits 10935 10942 +7
+ Misses 4616 4609 -7 |
What this PR solves / how to test
Fixes N/A.
This PR adds a section to the contributing guide on what you should do before getting started.
Author has addressed the following