-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Workers AI local mode fetcher not returning headers to client worker #5138
Conversation
🦋 Changeset detectedLatest commit: ee2da8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d01eb2a
to
3528f1f
Compare
3528f1f
to
1489650
Compare
Co-authored-by: MrBBot <me@mrbbot.dev>
Co-authored-by: MrBBot <me@mrbbot.dev>
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-wrangler-5138 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5138/npm-package-wrangler-5138 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-wrangler-5138 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-create-cloudflare-5138 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-cloudflare-kv-asset-handler-5138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-miniflare-5138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-cloudflare-pages-shared-5138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8138819560/npm-package-cloudflare-vitest-pool-workers-5138 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 70.32% 70.33%
=======================================
Files 298 298
Lines 15542 15546 +4
Branches 3999 4000 +1
=======================================
+ Hits 10930 10934 +4
Misses 4612 4612
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently test Workers AI in workers-sdk
, as it requires real account credentials and we're concerned about hitting rate limits, so approving this without tests. 👍
What this PR solves / how to test
Fixes Workers AI local mode fetcher not returning headers to client worker
Author has addressed the following