-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python support for remote dev #5119
Conversation
🦋 Changeset detectedLatest commit: ba75bbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aae3fcb
to
2531cd0
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5119/npm-package-wrangler-5119 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-create-cloudflare-5119 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-kv-asset-handler-5119 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-miniflare-5119 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-pages-shared-5119 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-vitest-pool-workers-5119 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
+ Coverage 70.33% 70.37% +0.03%
==========================================
Files 298 298
Lines 15515 15543 +28
Branches 3987 4000 +13
==========================================
+ Hits 10913 10938 +25
- Misses 4602 4605 +3
|
This PR makes sure that the bundle type is set correctly in remote dev mode when the main module is a Python module. It also ensures that the source URL annotation is written in Python style when the entry point is a Python module.
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.