More strict handling of requirement specifiers in requirements.txt. #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some discussion, the runtime team has decided that we should prevent users from specifying version identifiers altogether within requirements.txt, rather than silently dropping them. This would prevent users from being deluded into thinking that they could specify versions of Python packages in Python workers.
🦋 Changeset detectedLatest commit: 5a96e4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-wrangler-5118You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5118/npm-package-wrangler-5118Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-wrangler-5118 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-create-cloudflare-5118 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-cloudflare-kv-asset-handler-5118npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-miniflare-5118npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-cloudflare-pages-shared-5118npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116126052/npm-package-cloudflare-vitest-pool-workers-5118Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
=======================================
Coverage 70.33% 70.34%
=======================================
Files 298 298
Lines 15515 15546 +31
Branches 3987 3999 +12
=======================================
+ Hits 10913 10936 +23
- Misses 4602 4610 +8
|
garrettgu10
force-pushed
the
ggu/strict-requirements-txt
branch
from
1ff3aa0 to
e6f49a4
Compare
mrbbot
reviewed
Mar 1, 2024
packages/wrangler/src/deployment-bundle/find-additional-modules.ts
Outdated
Show resolved
Hide resolved
mrbbot
approved these changes
Mar 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion, the runtime team has decided that we should prevent users from specifying version identifiers altogether within requirements.txt, rather than silently dropping them. This would prevent users from being deluded into thinking that they could specify versions of Python packages in Python workers, then being confused because their code mysteriously breaks.
Fixes EW-8189.
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.