Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler: cleanup standard pricing check after legacy usage model deprecation #5035

Merged

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Feb 16, 2024

Fixes: WP-846

Cleans up some dead code paths after March 1st with the deprecation of the bundled/unbound usage models.

Do not merge until March 1st

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: No user facing changes
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: No user facing changes

@zebp zebp requested a review from a team as a code owner February 16, 2024 14:45
Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: 0d548ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zebp zebp changed the title Zeb/march 1st standard cleanup cleanup standard pricing check after legacy usage model deprecation Feb 16, 2024
@zebp zebp changed the title cleanup standard pricing check after legacy usage model deprecation [WIP] cleanup standard pricing check after legacy usage model deprecation Feb 16, 2024
Copy link
Contributor

github-actions bot commented Feb 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-wrangler-5035

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5035/npm-package-wrangler-5035

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-wrangler-5035 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-create-cloudflare-5035 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-kv-asset-handler-5035
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-miniflare-5035
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-pages-shared-5035
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-vitest-pool-workers-5035

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.31.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.1
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin marked this pull request as draft February 16, 2024 14:49
@petebacondarwin petebacondarwin added blocked Blocked on other work internal Requires support from the Cloudflare Platform labels Feb 16, 2024
@zebp zebp force-pushed the zeb/march-1st-standard-cleanup branch from fd8e6d6 to 0dd0552 Compare March 4, 2024 16:08
@zebp zebp changed the title [WIP] cleanup standard pricing check after legacy usage model deprecation wrangler: cleanup standard pricing check after legacy usage model deprecation Mar 4, 2024
@zebp zebp marked this pull request as ready for review March 4, 2024 16:08
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.41%. Comparing base (24e1dca) to head (0d548ba).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5035      +/-   ##
==========================================
+ Coverage   70.34%   70.41%   +0.07%     
==========================================
  Files         298      298              
  Lines       15567    15537      -30     
  Branches     4007     3999       -8     
==========================================
- Hits        10951    10941      -10     
+ Misses       4616     4596      -20     
Files Coverage Δ
packages/wrangler/src/deploy/index.ts 95.74% <100.00%> (-1.03%) ⬇️
packages/wrangler/src/versions/index.ts 27.27% <0.00%> (+4.35%) ⬆️

... and 6 files with indirect coverage changes

@zebp zebp force-pushed the zeb/march-1st-standard-cleanup branch from 0dd0552 to 0d548ba Compare March 6, 2024 14:15
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without changeset as the Date.now() >= Date.UTC(2024, 2, 1, 14) check would always pass, so this won't result in any user facing changes. 👍

Comment on lines +17 to +25
// TODO: remove the fake timers and irrelevant tests after March 1st
beforeAll(() => {
jest.useFakeTimers();
jest.setSystemTime(new Date(2024, 2, 2));
});

afterAll(() => {
jest.useRealTimers();
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use fake timers here anymore?

@petebacondarwin
Copy link
Contributor

@zebp - I assume that now we are passed March 1st this is no longer blocked?

@zebp
Copy link
Contributor Author

zebp commented Mar 11, 2024

@zebp - I assume that now we are passed March 1st this is no longer blocked?

Correct, I haven't had the time to find someone to merge this PR for me (I don't have access). I'll fix the feedback left on the PR tomorrow so this can be in the next release.

@petebacondarwin petebacondarwin merged commit aabae0f into cloudflare:main Mar 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work internal Requires support from the Cloudflare Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants