-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: cleanup standard pricing check after legacy usage model deprecation #5035
wrangler: cleanup standard pricing check after legacy usage model deprecation #5035
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-wrangler-5035 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5035/npm-package-wrangler-5035 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-wrangler-5035 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-create-cloudflare-5035 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-kv-asset-handler-5035 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-miniflare-5035 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-pages-shared-5035 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8173517816/npm-package-cloudflare-vitest-pool-workers-5035 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
fd8e6d6
to
0dd0552
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5035 +/- ##
==========================================
+ Coverage 70.34% 70.41% +0.07%
==========================================
Files 298 298
Lines 15567 15537 -30
Branches 4007 3999 -8
==========================================
- Hits 10951 10941 -10
+ Misses 4616 4596 -20
|
0dd0552
to
0d548ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving without changeset as the Date.now() >= Date.UTC(2024, 2, 1, 14)
check would always pass, so this won't result in any user facing changes. 👍
// TODO: remove the fake timers and irrelevant tests after March 1st | ||
beforeAll(() => { | ||
jest.useFakeTimers(); | ||
jest.setSystemTime(new Date(2024, 2, 2)); | ||
}); | ||
|
||
afterAll(() => { | ||
jest.useRealTimers(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use fake timers here anymore?
@zebp - I assume that now we are passed March 1st this is no longer blocked? |
Correct, I haven't had the time to find someone to merge this PR for me (I don't have access). I'll fix the feedback left on the PR tomorrow so this can be in the next release. |
Fixes: WP-846
Cleans up some dead code paths after March 1st with the deprecation of the bundled/unbound usage models.
Do not merge until March 1st